Small improvements to CI #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DigitalBrains1
force-pushed
the
improve-ci
branch
from
ec6b0a2 to
e169406
Compare
|
The current CI failure is unrelated, but I'm not going to rerun it to spare the electrons. This PR will be rebased for certain, so it's not the final run anyway. |
martijnbastiaan
approved these changes
Feb 7, 2025
Comment on lines
+10
to
+11
| s/__CHECK_HADDOCK__/$check_haddock/ | ||
| s/__CLASH_VERSION__/$clash_version/" |
There was a problem hiding this comment.
I had no idea you could chain commands like this. Cool.
We had two ways of setting -Werror: it was both in the `-fci` flag and in cabal.project.local. This was redundant. Constraining the Clash version can also be put in cabal.project.local.
The GitHub workflow file mentioned the master branch, but it's called main. Fixing this means we once again run CI on pushes to main.
Only the Haddock for clash-protocols was checked for warnings, and v2-sdist was only run for clash-protocols. The omission of clash-protocols-base was probably an oversight when splitting the package in two (#104).
This can drastically reduce CI running times when a PR is opened and it initially fails CI, as it no longer needs to rebuild dependencies on every new push.
DigitalBrains1
force-pushed
the
improve-ci
branch
from
e169406 to
84a5530
Compare
DigitalBrains1
commented
Feb 7, 2025
| on: | ||
| pull_request: | ||
| push: | ||
| branches: [master] | ||
| branches: [main] |
There was a problem hiding this comment.
Soooo.... why did the pushes to main not trigger a CI run? :-S
|
This is why:
It tries to run for main as well, it just stumbles on the fact that I'm opening a tiny PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a few points where CI could easily be improved a bit. See the individual commit messages for details.
I also bumped the Stack version in
stack.yamlto the latest LTS.